Green-on-white icon, with rounded corners #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zarino, Please merge it to fork/roost. I have tested it locally and the adaptive image looks crap. try create the adaptive image using android studio as explained here: |
|
Thanks @LiorAgnin 👍 I’ll submit an updated PR later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New icons for both the Android and iOS Roost apps.
The icon for both platforms is now a green "R" on a white background.
I’ve also attempted to define an "adaptive" icon for Android, but I’m not sure how to test whether it worked. Documentation is pretty poor on what sizes the adaptive icon assets should be, so I’ve just taken a guess. As a fallback, I‘ve also provided a precomposed Android icon with a background and rounded courners, so if the "adaptive" icon looks crap, feel free to just remove the adaptive icon settings from the pubspec.
@LiorAgnin let me know if anything doesn’t work out as expected.
Also, let me know if
fork/roost_mergeisn‘t the right branch to PR against. I can cherry-pick onto a different branch if you’d prefer.